linux-kernel - Re: [PATCH V3 2/3] arm64: dts: imx8mp: Add micfil node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Oct 2023 07:15:30 -0500
From:   Adam Ford <aford173@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, marex@...x.de,
        aford@...conembedded.com, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        Abel Vesa <abelvesa@...nel.org>, Peng Fan <peng.fan@....com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH V3 2/3] arm64: dts: imx8mp: Add micfil node

On Tue, Oct 3, 2023 at 8:12 PM Fabio Estevam <festevam@...il.com> wrote:
>
> Hi Adam and devicetree folks,
>
> On Thu, Aug 31, 2023 at 1:44 AM Adam Ford <aford173@...il.com> wrote:
> >
> > The i.MX8MP has a micfil controller which is used for interfacing
> > with a pulse density microphone. Add the node and mark it as
> > disabled by default.
> >
> > Signed-off-by: Adam Ford <aford173@...il.com>
> > ---
> > V3:  The AUDIOMIX_PDM_ROOT doesn't exist and the real clock is
> >      called IMX8MP_CLK_AUDIOMIX_PDM_SEL, so swap it out.
> >
> > V2:  No change
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 3167706d81e1..341fd0369ce9 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -1479,6 +1479,27 @@ easrc: easrc@...90000 {
> >                                         fsl,asrc-format = <2>;
> >                                         status = "disabled";
> >                                 };
> > +
> > +                               micfil: audio-controller@...a0000 {
> > +                                       compatible = "fsl,imx8mp-micfil";
> > +                                       reg = <0x30ca0000 0x10000>;
> > +                                       #sound-dai-cells = <0>;
>
> After this patch, the following schema warning is seen:
>
> imx8mp-beacon-kit.dtb: audio-controller@...a0000: '#sound-dai-cells'
> does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/sound/fsl,micfil.yaml#
>
> What is the correct way to solve this?
>
> - Document #sound-dai-cells in fsl,micfil.yaml as an optional property
> - Remove #sound-dai-cells from imx8mp.dtsi
> - Document #sound-dai-cells in fsl,micfil.yaml as a required property
> and pass #sound-dai-cells to imx8mm/imx8mn/imx83.dtsi?

I am not an expert on yaml, in fact they quite confuse me, but I
believe the proper solution is likely to document them in the yaml.
When I built the device tree without the sound-dai-cells, it threw a
message indicating that it needed to be there when it is configured to
operate.  I didn't see the schema warning that you noted, but my
schema could have been out of date.  Looking at the sai nodes and the
yaml file, it appears that the sound-dai-cells is listed in the yaml.

adam