linux-kernel - RE: [PATCH v2 4/6] drivers: soc: xilinx: Fix error message on SGI registration failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR12MB4465A8A84D28A1AC444AB53C9DCBA@DM6PR12MB4465.namprd12.prod.outlook.com>
Date:   Wed, 4 Oct 2023 12:48:25 +0000
From:   "Buddhabhatti, Jay" <jay.buddhabhatti@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "Simek, Michal" <michal.simek@....com>,
        "Shah, Tanmay" <tanmay.shah@....com>,
        "Manne, Nava kishore" <nava.kishore.manne@....com>,
        "Levinsky, Ben" <ben.levinsky@....com>,
        "robh@...nel.org" <robh@...nel.org>,
        "marex@...x.de" <marex@...x.de>,
        "Shaikh, Izhar Ameer" <izhar.ameer.shaikh@....com>,
        "arnd@...db.de" <arnd@...db.de>,
        "ruanjinjie@...wei.com" <ruanjinjie@...wei.com>,
        "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2 4/6] drivers: soc: xilinx: Fix error message on SGI
 registration failure

Hi Greg,

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Wednesday, October 4, 2023 5:45 PM
> To: Buddhabhatti, Jay <jay.buddhabhatti@....com>
> Cc: Simek, Michal <michal.simek@....com>; Shah, Tanmay
> <tanmay.shah@....com>; Manne, Nava kishore
> <nava.kishore.manne@....com>; Levinsky, Ben <ben.levinsky@....com>;
> robh@...nel.org; dhaval.r.shah@....com; marex@...x.de; Shaikh, Izhar
> Ameer <izhar.ameer.shaikh@....com>; arnd@...db.de;
> ruanjinjie@...wei.com; mathieu.poirier@...aro.org; linux-
> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH v2 4/6] drivers: soc: xilinx: Fix error message on SGI
> registration failure
> 
> On Wed, Oct 04, 2023 at 02:41:14AM -0700, Jay Buddhabhatti wrote:
> > Failure to register SGI for firmware event notification is non-fatal
> > error when feature is not supported by other modules such as Xen and
> > TF-A. Add _info level log message for such special case.
> >
> > Also add XST_PM_INVALID_VERSION error code and map it to -EOPNOSUPP
> > Linux kernel error code. If feature is not supported or EEMI API
> > version is mismatch, firmware can return XST_PM_INVALID_VERSION = 4 or
> > XST_PM_NO_FEATURE = 19 error code.
> >
> > Co-developed-by: Tanmay Shah <tanmay.shah@....com>
> > Signed-off-by: Tanmay Shah <tanmay.shah@....com>
> > Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@....com>
> > ---
> >  drivers/firmware/xilinx/zynqmp.c        | 4 +++-
> >  drivers/soc/xilinx/xlnx_event_manager.c | 7 ++++++-
> >  include/linux/firmware/xlnx-zynqmp.h    | 1 +
> >  3 files changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/firmware/xilinx/zynqmp.c
> > b/drivers/firmware/xilinx/zynqmp.c
> > index 00ea2508f692..de09d77cf1e4 100644
> > --- a/drivers/firmware/xilinx/zynqmp.c
> > +++ b/drivers/firmware/xilinx/zynqmp.c
> > @@ -92,6 +92,8 @@ static int zynqmp_pm_ret_code(u32 ret_status)
> >  		return 0;
> >  	case XST_PM_NO_FEATURE:
> >  		return -ENOTSUPP;
> > +	case XST_PM_INVALID_VERSION:
> > +		return -EOPNOTSUPP;
> >  	case XST_PM_NO_ACCESS:
> >  		return -EACCES;
> >  	case XST_PM_ABORT_SUSPEND:
> > @@ -379,7 +381,7 @@ int zynqmp_pm_register_sgi(u32 sgi_num, u32 reset)
> >
> >  	ret = zynqmp_pm_invoke_fn(TF_A_PM_REGISTER_SGI, sgi_num, reset,
> 0, 0,
> >  				  0, NULL);
> > -	if (!ret)
> > +	if (ret != -EOPNOTSUPP && !ret)
> >  		return ret;
> >
> >  	/* try old implementation as fallback strategy if above fails */
> > diff --git a/drivers/soc/xilinx/xlnx_event_manager.c
> > b/drivers/soc/xilinx/xlnx_event_manager.c
> > index 38cfc161a713..bfa5cf4a0cab 100644
> > --- a/drivers/soc/xilinx/xlnx_event_manager.c
> > +++ b/drivers/soc/xilinx/xlnx_event_manager.c
> > @@ -653,7 +653,12 @@ static int xlnx_event_manager_probe(struct
> > platform_device *pdev)
> >
> >  	ret = zynqmp_pm_register_sgi(sgi_num, 0);
> >  	if (ret) {
> > -		dev_err(&pdev->dev, "SGI %d Registration over TF-A failed with
> %d\n", sgi_num, ret);
> > +		if (ret == -EOPNOTSUPP)
> > +			dev_info(&pdev->dev, "PM firmware event notification
> not
> > +supported\n");
> 
> Why is this "info"?  Why not error?
[Jay] Because it is non-fatal error which will not cause kernel crash.

> 
> And what is userspace supposed to do with this information if it sees it?
[Jay] This message indicates that SGI registration is not supported by other modules like TF-A or Xen. So user need to use TF-A with this support if they want to use event management driver.

Thanks,
Jay
> 
> thanks,
> 
> greg k-h