linux-kernel - Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the absence of ACPI enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cac56745-f611-48c2-bb1b-e86a3694fa59@kernel.org>
Date:   Wed, 4 Oct 2023 15:20:01 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andy@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v1 1/1] pinctrl: denverton: Enable platform device in the
 absence of ACPI enumeration

On 04/10/2023 15:09, Andy Shevchenko wrote:
> On Wed, Oct 4, 2023 at 11:18 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>> On 26/09/2023 21:08, Andy Shevchenko wrote:
> 
> ...
> 
>>> +MODULE_ALIAS("platform:denverton-pinctrl");
>>
>> Why do you need the alias? It's the same as ID table. You most likely
>> miss MODULE_DEVICE_TABLE() or your table is just wrong.
> 
> This is cargo cult from pinctrl-broxton.c. If we want to fix, we need
> to fix both.
> Care to send patches?

I don't understand how some other file affects this. Why do you exactly
need module alias here? Which use-case does not work without it (after
adding proper MODULE_DEVICE_TABLE())?

Best regards,
Krzysztof