linux-kernel - Re: [PATCH v2] wifi: wfx: fix case where rates are out of order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y1gi5xq3.fsf@kernel.org>
Date:   Wed, 04 Oct 2023 16:22:12 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     Jérôme Pouiller <jerome.pouiller@...abs.com>
Cc:     linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        Felix Fietkau <nbd@....name>,
        Felipe Negrelli Wolter <felipe.negrelliwolter@...abs.com>,
        Olivier Souloumiac <olivier.souloumiac@...abs.com>,
        Alexandr Suslenko <suslenko.o@...x.systems>
Subject: Re: [PATCH v2] wifi: wfx: fix case where rates are out of order

Jérôme Pouiller <jerome.pouiller@...abs.com> writes:

>> > v2:
>> >   - Fix malformed tags in commit body. (checkpatch still complains about
>> >     missing Close tag, but the bug tracker is not public and I don't have
>> >     the exact URL)
>> 
>> Just out of curiosity why does the checkpatch complain about a missing
>> Close tag? I don't get it why there should be one.
>
> I am on top of v6.6-rc3. I get:
>
>     $ ./scripts/checkpatch.pl -g HEAD^..HEAD
>     WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
>     #26:
>                       best    ____________rate__________    ____statistics___    _____last____    ______sum-of________
>
>     WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
>     #57:
>     Reported-by: Alexandr Suslenko <suslenko.o@...x.systems>
>     Co-developed-by: Jérôme Pouiller <jerome.pouiller@...abs.com>
>     [...]

Ah, thanks. Now I understand. But that rule doesn't make any sense to
me, for example I get reports privately as well and add a Reported-by
without a Closes tag. So always feel free to ignore that checkpatch
warning.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches