linux-kernel - Re: [PATCH v2] dmaengine: idxd: Remove redundant memset() for eventlog allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZR1tSu0IQHFNuqMo@matsya>
Date:   Wed, 4 Oct 2023 19:18:58 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     coolrrsh@...il.com
Cc:     fenghua.yu@...el.com, dave.jiang@...el.com,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v2] dmaengine: idxd: Remove redundant memset() for
 eventlog allocation

On 29-08-23, 23:30, coolrrsh@...il.com wrote:
> From: Rajeshwar R Shinde <coolrrsh@...il.com>
> 
> dma_alloc_coherent function already zeroes the array 'addr'.
> So, memset function call is not needed.
> 
> This fixes warning such as:
> drivers/dma/idxd/device.c:783:8-26:
> WARNING: dma_alloc_coherent used in addr already zeroes out memory,
> so memset is not needed.

Already fixes by 4ca95a5b220c901f9c2402532ef78bf5aaf7d35d

> 
> Signed-off-by: Rajeshwar R Shinde <coolrrsh@...il.com>
> ---
> v1->v2
> Renamed the subject line
> ---
>  drivers/dma/idxd/device.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 5abbcc61c528..7c74bc60f582 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -786,8 +786,6 @@ static int idxd_device_evl_setup(struct idxd_device *idxd)
>  		goto err_alloc;
>  	}
>  
> -	memset(addr, 0, size);
> -
>  	spin_lock(&evl->lock);
>  	evl->log = addr;
>  	evl->dma = dma_addr;
> -- 
> 2.25.1

-- 
~Vinod