linux-kernel - Re: [PATCH v3 03/17] firmware: arm_ffa: Implement the notification bind and unbind interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Oct 2023 16:32:34 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Olivier Deprez <Olivier.Deprez@....com>
Cc:     Jens Wiklander <jens.wiklander@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Marc Bonnici <Marc.Bonnici@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Coboy Chen <coboy.chen@...iatek.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>
Subject: Re: [PATCH v3 03/17] firmware: arm_ffa: Implement the notification
 bind and unbind interface

On Wed, Oct 04, 2023 at 10:50:26AM +0100, Olivier Deprez wrote:
> Hi Jens,
> 
> > dst_id and drv_info->vm_id should be swapped.
> 
> I'm curious about this because swapping like this actually makes hafnium
> fail. Need to check from the spec.

I did check after I had swapped this in v2(because I was convinced Jens) was
correct and you reported the failure. Reading the spec again the other day,
I got corrected myself and agreed with Olivier and my original
implementation(v1) which matches this patch(v3).

-- 
Regards,
Sudeep