linux-kernel - Re: [PATCH] Firewire: IP over IEEE 1394: replaced implicit mentions of unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231004040349.GA53158@workstation.local>
Date:   Wed, 4 Oct 2023 13:03:49 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Kai Bosch <kellerassel@...il.com>
Cc:     linux1394-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, Kai Bosch <kbosch@...tonmail.com>
Subject: Re: [PATCH] Firewire: IP over IEEE 1394: replaced implicit mentions
 of unsigned int

Hi,

Thanks for your sending the patch.

On Tue, Oct 03, 2023 at 09:16:50PM +0000, Kai Bosch wrote:
> ---
>  drivers/firewire/net.c | 48 +++++++++++++++++++++---------------------
>  1 file changed, 24 insertions(+), 24 deletions(-)

As long as I know, the coding style of Linux kernel[1] does not forbidden
brief expression of 'unsigned int' (= just 'unsigned'). Furthermore,
in C language specification, 'unsigned' and 'unsigned int' are the
same[2]. I have no functional change over the patch.

If the intension of patch is in the point of human readability, please
note it in the commit comment. It is the most important for the kind of
change.

I'm waiting for your next post.

[1] Linux kernel coding style
https://www.kernel.org/doc/html/v4.10/process/coding-style.html
[2] See '6.7.2 Type specifiers' in ISO/IEC 9899:1999, so called 'C99'.

Regards

Takashi Sakamoto