linux-kernel - Re: [PATCH v8 0/8] soc: mediatek: MT8365 power support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <06f8a769-1845-ea87-dcc4-37dd5ad255ed@collabora.com>
Date:   Thu, 5 Oct 2023 10:54:16 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Markus Schneider-Pargmann <msp@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Alexandre Mergnat <amergnat@...libre.com>,
        Chun-Jie Chen <chun-jie.chen@...iatek.com>,
        Tinghan Shen <tinghan.shen@...iatek.com>,
        Fabien Parent <parent.f@...il.com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v8 0/8] soc: mediatek: MT8365 power support

Il 18/09/23 11:37, Markus Schneider-Pargmann ha scritto:
> Hi,
> 
> no real changes in this update. Rebase to v6.6-rc2 and according change
> of directory.

Since the driver changed to pmdomain/mediatek, can you please change the commit
titles for the driver commits?

soc: mediatek: pm-domains: ===> pmdomain: mediatek: pm-domains:

or alternatively, I honestly would like it more like

pmdomain: mediatek: pd:

and (not relevant to this series)

pmdomain: mediatek: scpsys:

...but before that, does anyone have any strong opinions against the prefix
"pmdomain: mediatek: pd:", instead of the full "pm-domains"?

Thanks!
Angelo

> 
> Thanks for any feedback!
> 
> Best,
> Markus
> 
> Based on v6.6-rc2
> 
> Changes in v8:
> - Rebased to v6.6-rc2
> - Moved changes from drivers/soc to drivers/pmdomain
> 
> Changes in v7:
> - Rebased to v6.5-rc1
> - Fixed a couple of small style issues pointed out by Angelo
> 
> Changes in v6:
> - Change flags field to be u8 instead of u32
> - Use macro concatenation to simplify BUS_PROT macros:
>    BUS_PROT_WR(_hwip, ...) etc.
> - Use the final bit values for scpsys_bus_prot_flags from the beginning
>    of the series.
> - Changed scpsys_domain_data->caps to be u16 to accommodate the new flag
>    MTK_SCPD_STRICT_BUS_PROTECTION.
> 
> Changes in v5:
> - Create defines for all registers and bits in mt8365 power domain patch
> - Redesign scpsys_bus_prot_data to use flags to store reg_update,
>    clr_ack as well as the difference between SMI and INFRACFG. The code
>    uses the appropriate regmap depending on the flags.
> - The WAY_EN patch now uses two flags, one for inverted operations
>    'BUS_PROT_INVERTED' and one to use infracfg-nao for the status flags
>    'BUS_PROT_STA_COMPONENT_INFRA_NAO'.
> 
> Changes in v4:
> - Redesigned WAY_EN patch and split it up in smaller patches.
> - Added two documentation patches.
> - Added mediatek,infracfg-nao field to the binding.
> 
> Changes in v3:
> - Mainly redesigned WAY_EN patch to be easier to understand
> - Rebased onto v6.0-rc1
> - Several other stuff that is described in the individual patches
> 
> Changes in v2:
> - Updated error handling path for scpsys_power_on()
> - Minor updates described in each patch
> 
> Previous versions:
> v1 - https://lore.kernel.org/linux-mediatek/20220530204214.913251-1-fparent@baylibre.com/
> v2 - https://lore.kernel.org/linux-mediatek/20220725081853.1636444-1-msp@baylibre.com/
> v3 - https://lore.kernel.org/linux-mediatek/20220822144303.3438467-1-msp@baylibre.com/
> v4 - https://lore.kernel.org/linux-arm-kernel/20230105170735.1637416-1-msp@baylibre.com/
> v5 - https://lore.kernel.org/linux-arm-kernel/20230619085344.2885311-1-msp@baylibre.com/
> v6 - https://lore.kernel.org/linux-arm-kernel/20230627131040.3418538-1-msp@baylibre.com/
> v7 - https://lore.kernel.org/linux-arm-kernel/20230713150414.891893-1-msp@baylibre.com
> 
> Alexandre Bailon (2):
>    soc: mediatek: Add support for WAY_EN operations
>    soc: mediatek: Add support for MTK_SCPD_STRICT_BUS_PROTECTION cap
> 
> Fabien Parent (2):
>    dt-bindings: power: Add MT8365 power domains
>    soc: mediatek: pm-domains: Add support for MT8365
> 
> Markus Schneider-Pargmann (4):
>    soc: mediatek: pm-domains: Move bools to a flags field
>    soc: mediatek: pm-domains: Split bus_prot_mask
>    soc: mediatek: pm-domains: Create bus protection operation functions
>    soc: mediatek: pm-domains: Unify configuration for infracfg and smi
> 
>   .../power/mediatek,power-controller.yaml      |   6 +
>   drivers/pmdomain/mediatek/mt6795-pm-domains.h |  16 +-
>   drivers/pmdomain/mediatek/mt8167-pm-domains.h |  20 +-
>   drivers/pmdomain/mediatek/mt8173-pm-domains.h |  16 +-
>   drivers/pmdomain/mediatek/mt8183-pm-domains.h | 125 ++++++----
>   drivers/pmdomain/mediatek/mt8186-pm-domains.h | 236 ++++++++++--------
>   drivers/pmdomain/mediatek/mt8188-pm-domains.h | 223 +++++++++++------
>   drivers/pmdomain/mediatek/mt8192-pm-domains.h | 112 ++++++---
>   drivers/pmdomain/mediatek/mt8195-pm-domains.h | 199 +++++++++------
>   drivers/pmdomain/mediatek/mt8365-pm-domains.h | 197 +++++++++++++++
>   drivers/pmdomain/mediatek/mtk-pm-domains.c    | 157 ++++++++----
>   drivers/pmdomain/mediatek/mtk-pm-domains.h    |  51 ++--
>   .../dt-bindings/power/mediatek,mt8365-power.h |  19 ++
>   include/linux/soc/mediatek/infracfg.h         |  41 +++
>   14 files changed, 972 insertions(+), 446 deletions(-)
>   create mode 100644 drivers/pmdomain/mediatek/mt8365-pm-domains.h
>   create mode 100644 include/dt-bindings/power/mediatek,mt8365-power.h
> 
> 
> base-commit: ce9ecca0238b140b88f43859b211c9fdfd8e5b70