linux-kernel - Re: [PATCH v2 1/2] dt-bindings: iio: adc: ti,ads7038: Add description for ADS7038

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2e2d122-f5a7-401e-a429-0a86c2c0b3ab@linaro.org>
Date:   Thu, 5 Oct 2023 09:33:26 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     werneazc@...il.com, jic23@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        lars@...afoo.de
Cc:     devicetree@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Andre Werner <andre.werner@...tec-electronic.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: ti,ads7038: Add description
 for ADS7038

On 05/10/2023 05:54, werneazc@...il.com wrote:
> From: Andre Werner <andre.werner@...tec-electronic.com>
> 
> Add basic description for ADS7x38 ADC devices. The driver does only
> support a very basic set of functionalities provided by the chip.
> Also, the example in the description covers only a setup for ADS7038 devices
> while the driver structure will support both ADS7038 (SPI) and ADS7138 (I2C) devices.
> 
> Signed-off-by: Andre Werner <andre.werner@...tec-electronic.com>
> ---
> - v2: Add commit message and correct vref-description copy-paste-error.
> ---
>  .../bindings/iio/adc/ti,ads7038.yaml          | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
> new file mode 100644
> index 000000000000..d40869b9a604
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,ads7038.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ADS7038 and similar ADCs
> +
> +maintainers:
> +  - Andre Werner <andre.werner@...tec-electronic.com>
> +
> +description: |
> +  Family of 7 channel, 12 bit ADCs with SPI/I2C interface.
> +
> +  Datasheet: https://www.ti.com/lit/gpn/ads7038
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,ads7038
> +      - ti,ads7138
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-max-frequency:
> +    maximum: 60000000
> +
> +  vref-supply:
> +    description: Supplies the reference voltage AVDD

Didn't you already get a comment that there is no vref but avdd, so
avdd-supply?


Best regards,
Krzysztof