[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SG2PR06MB3365ED5D60E709045FD010F38BCAA@SG2PR06MB3365.apcprd06.prod.outlook.com>
Date: Thu, 5 Oct 2023 01:04:32 +0000
From: Billy Tsai <billy_tsai@...eedtech.com>
To: Rob Herring <robh@...nel.org>
CC: "jdelvare@...e.com" <jdelvare@...e.com>,
"linux@...ck-us.net" <linux@...ck-us.net>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"joel@....id.au" <joel@....id.au>,
"andrew@...id.au" <andrew@...id.au>,
"corbet@....net" <corbet@....net>,
"thierry.reding@...il.com" <thierry.reding@...il.com>,
"u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"naresh.solanki@...ements.com" <naresh.solanki@...ements.com>,
"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
BMC-SW <BMC-SW@...eedtech.com>,
"patrick@...cx.xyz" <patrick@...cx.xyz>
Subject: Re: [PATCH v9 1/3] dt-bindings: hwmon: fan: Add fan binding to schema
>> From: Naresh Solanki <naresh.solanki@...ements.com>
>>
>> Add common fan properties bindings to a schema.
>>
>> Bindings for fan controllers can reference the common schema for the
>> fan
>>
>> child nodes:
>>
>> patternProperties:
>> "^fan@[0-2]":
>> type: object
>> $ref: fan-common.yaml#
>> unevaluatedProperties: false
>>
>> Signed-off-by: Naresh Solanki <naresh.solanki@...ements.com>
>> Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>
>> ---
>> .../devicetree/bindings/hwmon/fan-common.yaml | 78 +++++++++++++++++++
>> 1 file changed, 78 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
>> new file mode 100644
>> index 000000000000..2bd2f57fc9d9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
>> @@ -0,0 +1,78 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Common Fan Properties
>> +
>> +maintainers:
>> + - Naresh Solanki <naresh.solanki@...ements.com>
>> + - Billy Tsai <billy_tsai@...eedtech.com>
>> +
>> +properties:
>> + max-rpm:
>> + description:
>> + Max RPM supported by fan.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + maximum: 100000
>> +
>> + min-rpm:
>> + description:
>> + Min RPM supported by fan.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + maximum: 1000
>> +
>> + pulses-per-revolution:
>> + description:
>> + The number of pulse from fan sensor per revolution.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + maximum: 4
>> +
>> + tach-div:
>> + description:
>> + Divisor for the tach sampling clock, which determines the sensitivity of the tach pin.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + target-rpm:
>> + description:
>> + The default desired fan speed in RPM.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + fan-driving-mode:
>> + description:
>> + Select the driving mode of the fan.(DC, PWM and so on)
>> + $ref: /schemas/types.yaml#/definitions/uint32
> What value corresponds to what mode? I'd do strings instead. 'dc',
> 'pwm', etc.
Ok, I will change the type to the string for next patch.
Thanks
Powered by blists - more mailing lists