linux-kernel - Re: [PATCH v7 2/3] greybus: Add BeaglePlay Linux Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023100536-lumping-gauntlet-3a55@gregkh>
Date:   Thu, 5 Oct 2023 12:39:47 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ayush Singh <ayushdevel1325@...il.com>
Cc:     greybus-dev@...ts.linaro.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, vaishnav@...gleboard.org,
        jkridner@...gleboard.org, nm@...com,
        krzysztof.kozlowski+dt@...aro.org, johan@...nel.org,
        elder@...nel.org
Subject: Re: [PATCH v7 2/3] greybus: Add BeaglePlay Linux Driver

On Thu, Oct 05, 2023 at 03:18:15PM +0530, Ayush Singh wrote:
> 
> On 10/5/23 14:38, Greg KH wrote:
> > On Thu, Oct 05, 2023 at 12:16:37AM +0530, Ayush Singh wrote:
> > > Add the Greybus host driver for BeaglePlay board by BeagleBoard.org.
> > > 
> > > The current greybus setup involves running SVC in a user-space
> > > application (GBridge) and using netlink to communicate with kernel
> > > space. GBridge itself uses wpanusb kernel driver, so the greybus messages
> > > travel from kernel space (gb_netlink) to user-space (GBridge) and then
> > > back to kernel space (wpanusb) before reaching CC1352.
> > > 
> > > This driver directly communicates with CC1352 (running SVC Zephyr
> > > application). Thus, it simplifies the complete greybus setup eliminating
> > > user-space GBridge.
> > > 
> > > This driver is responsible for the following:
> > > - Start SVC (CC1352) on driver load.
> > > - Send/Receive Greybus messages to/from CC1352 using HDLC over UART.
> > > - Print Logs from CC1352.
> > > - Stop SVC (CC1352) on driver load.
> > > 
> > > Signed-off-by: Ayush Singh <ayushdevel1325@...il.com>
> > > ---
> > >   MAINTAINERS                     |   1 +
> > >   drivers/greybus/Kconfig         |  10 +
> > >   drivers/greybus/Makefile        |   2 +
> > >   drivers/greybus/gb-beagleplay.c | 501 ++++++++++++++++++++++++++++++++
> > >   4 files changed, 514 insertions(+)
> > >   create mode 100644 drivers/greybus/gb-beagleplay.c
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 5467669d7963..d87e30626a6a 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -8974,6 +8974,7 @@ M:	Ayush Singh <ayushdevel1325@...il.com>
> > >   L:	greybus-dev@...ts.linaro.org (moderated for non-subscribers)
> > >   S:	Maintained
> > >   F:	Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> > > +F:	drivers/greybus/gb-beagleplay.c
> > >   GREYBUS SUBSYSTEM
> > >   M:	Johan Hovold <johan@...nel.org>
> > > diff --git a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig
> > > index 78ba3c3083d5..fd4f26d09c53 100644
> > > --- a/drivers/greybus/Kconfig
> > > +++ b/drivers/greybus/Kconfig
> > > @@ -17,6 +17,16 @@ menuconfig GREYBUS
> > >   if GREYBUS
> > > +config GREYBUS_BEAGLEPLAY
> > > +	tristate "Greybus BeaglePlay driver"
> > > +	depends on TTY
> > What you want to depend on here is serdev, not tty, right?  Or am I
> > mis-reading the code requirements?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Yes, it was dependent on tty in the past, but not anymore. I think it should
> be changed to `SERIAL_DEV_BUS` now?

Yes, otherwise you will get build errors.

thanks,

greg k-h