linux-kernel - Re: [PATCH V14 4/4] arm64: dts: qcom: ipq6018: add pwm node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4de85592-ab53-4528-cc98-3ad5fc128032@quicinc.com>
Date:   Thu, 5 Oct 2023 13:03:51 +0530
From:   Devi Priya <quic_devipriy@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <lee@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <thierry.reding@...il.com>, <ndesaulniers@...gle.com>,
        <trix@...hat.com>, <baruch@...s.co.il>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <llvm@...ts.linux.dev>
CC:     <linux-pwm@...r.kernel.org>, <u.kleine-koenig@...gutronix.de>,
        <nathan@...nel.org>
Subject: Re: [PATCH V14 4/4] arm64: dts: qcom: ipq6018: add pwm node



On 10/5/2023 1:00 PM, Krzysztof Kozlowski wrote:
> On 05/10/2023 06:31, Devi Priya wrote:
>> Describe the PWM block on IPQ6018.
>>
>> The PWM is in the TCSR area. Make &tcsr "simple-mfd" compatible, and add
>> &pwm as child of &tcsr.
>>
>> Add also ipq6018 specific compatible string.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Co-developed-by: Baruch Siach <baruch.siach@...lu.com>
>> Signed-off-by: Baruch Siach <baruch.siach@...lu.com>
>> Signed-off-by: Devi Priya <quic_devipriy@...cinc.com>
>> ---
>> v14:
>>
>>    Moved ranges just after reg as suggested by Krzysztof
>>
>>    Picked up the R-b tag
>>
>> v13:
>>
>>    No change
>>
>> v12:
>>
>>    No change
>>
>> v11:
>>
>>    No change
>>
>> v10:
>>
>>    No change
>>
>> v9:
>>
>>    Add 'ranges' property (Rob)
>>
>> v8:
>>
>>    Add size cell to 'reg' (Rob)
>>
>> v7:
>>
>>    Use 'reg' instead of 'offset' (Rob)
>>
>>    Add qcom,tcsr-ipq6018 (Rob)
>>
>>    Drop clock-names (Bjorn)
>>
>> v6:
>>
>>    Make the PWM node child of TCSR (Rob Herring)
>>
>>    Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König)
>>
>> v5: Use qcom,pwm-regs for TCSR phandle instead of direct regs
>>
>> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)
>>
>>   arch/arm64/boot/dts/qcom/ipq6018.dtsi | 15 ++++++++++++++-
>>   1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> index e59b9df96c7e..565e61ce382f 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> @@ -390,8 +390,21 @@ tcsr_mutex: hwlock@...5000 {
>>   		};
>>   
>>   		tcsr: syscon@...7000 {
>> -			compatible = "qcom,tcsr-ipq6018", "syscon";
>> +			compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
>>   			reg = <0x0 0x01937000 0x0 0x21000>;
>> +			ranges = <0x0 0x0 0x01937000 0x21000>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +
>> +			 pwm: pwm@...0 {
> 
> Broken indentation.

Oops, sorry! will fix it up

Thanks,
Devi Priya
> 
> Best regards,
> Krzysztof
>