linux-kernel - Re: [PATCH] thermal: intel: powerclamp: fix mismatch in get function for max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff3f7c023d73c2c8216cff2910e4965a026cdd98.camel@linux.intel.com>
Date:   Thu, 05 Oct 2023 08:09:34 -0700
From:   srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     David Arcari <darcari@...hat.com>, linux-pm@...r.kernel.org
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>, Chen Yu <yu.c.chen@...el.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] thermal: intel: powerclamp: fix mismatch in get
 function for max_idle

On Thu, 2023-10-05 at 07:17 -0400, David Arcari wrote:
> KASAN reported this
> 
>       [ 444.853098] BUG: KASAN: global-out-of-bounds in
> param_get_int+0x77/0x90
>       [ 444.853111] Read of size 4 at addr ffffffffc16c9220 by task
> cat/2105
>       ...
>       [ 444.853442] The buggy address belongs to the variable:
>       [ 444.853443] max_idle+0x0/0xffffffffffffcde0
> [intel_powerclamp]
> 
> There is a mismatch between the param_get_int and the definition of
> max_idle.  Replacing param_get_int with param_get_byte resolves this
> issue.
> 
> Fixes: ebf519710218 ("thermal: intel: powerclamp: Add two module
> parameters")
> 
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Amit Kucheria <amitk@...nel.org>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: David Arcari <darcari@...hat.com>
> Cc: Chen Yu <yu.c.chen@...el.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: stable@...r.kernel.org
> Signed-off-by: David Arcari <darcari@...hat.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
>  drivers/thermal/intel/intel_powerclamp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/intel/intel_powerclamp.c
> b/drivers/thermal/intel/intel_powerclamp.c
> index 36243a3972fd..5ac5cb60bae6 100644
> --- a/drivers/thermal/intel/intel_powerclamp.c
> +++ b/drivers/thermal/intel/intel_powerclamp.c
> @@ -256,7 +256,7 @@ static int max_idle_set(const char *arg, const
> struct kernel_param *kp)
>  
>  static const struct kernel_param_ops max_idle_ops = {
>         .set = max_idle_set,
> -       .get = param_get_int,
> +       .get = param_get_byte,
>  };
>  
>  module_param_cb(max_idle, &max_idle_ops, &max_idle, 0644);