linux-kernel - Re: [PATCH v7 1/3] dt-bindings: net: Add ti,cc1352p7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231005111907.ck6rhmuhicrjkifr@elderly>
Date:   Thu, 5 Oct 2023 06:19:07 -0500
From:   Nishanth Menon <nm@...com>
To:     Ayush Singh <ayushdevel1325@...il.com>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <greybus-dev@...ts.linaro.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>,
        <vaishnav@...gleboard.org>, <jkridner@...gleboard.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <vigneshr@...com>,
        <kristo@...nel.org>, <robh+dt@...nel.org>, <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v7 1/3] dt-bindings: net: Add ti,cc1352p7

On 13:51-20231005, Ayush Singh wrote:
> > > Signed-off-by: Ayush Singh <ayushdevel1325@...il.com>
> > > ---
> > >   .../devicetree/bindings/net/ti,cc1352p7.yaml  | 51 +++++++++++++++++++
> > >   MAINTAINERS                                   |  6 +++
> > >   2 files changed, 57 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> > > new file mode 100644
> > > index 000000000000..291ba34c389b
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml
> > > @@ -0,0 +1,51 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/net/ti,cc1352p7.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Texas Instruments Simplelink CC1352P7 wireless MCU
> > > +
> > > +description:
> > > +  The cc1352p7 mcu can be connected via SPI or UART.
> > > +
> > > +maintainers:
> > > +  - Ayush Singh <ayushdevel1325@...il.com>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: ti,cc1352p7
> > > +
> > > +  clocks:
> > > +    maxItems: 2
> > > +
> > > +  clock-names:
> > > +    description:
> > > +      sclk_hf is the main system (mcu and peripherals) clock
> > > +      sclk_lf is low-frequency system clock
> > This does no go here, but to clocks. I wrote how it should be done.
> > Don't ignore the feedback.
> It was suggested to use `clock-names` by Nishanth Menon in the previous
> email, so I thought this was what it meant. I will remove clock-names if
> that's better.

Krzysztof was mentioning that the description should be with clocks.
clock-names would allow for more descriptive dts

> > > +    items:
> > > +      - const: sclk_hf
> > > +      - const: sclk_lf
> > > +
> > > +  reset-gpios: true
> > 
> > No, really, why do you change correct code into incorrect one? Who asked
> > you to drop maxItems?
> I found that many bindings (`display/ilitek,ili9486.yaml`,
> `iio/dac/adi,ad5758.yaml`) use this pattern instead of `maxItems` for
> `reset-gpios`. So I assumed it was some sort of convention. I will change it
> back to `maxItems`.

maxItems restrict the number of GPIOs to the ones that are actually
needed for the peripheral.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D