linux-kernel - Re: [PATCH v4 2/3] dt-bindings: usb: ci-hdrc-usb2: add npcm750 and npcm845 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Oct 2023 13:27:25 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Tomer Maimon <tmaimon77@...il.com>
Cc:     peter.chen@...nel.org, gregkh@...uxfoundation.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        xu.yang_2@....com, peng.fan@....com, avifishman70@...il.com,
        tali.perry1@...il.com, joel@....id.au, venture@...gle.com,
        yuenn@...gle.com, benjaminfair@...gle.com, j.neuschaefer@....net,
        openbmc@...ts.ozlabs.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: usb: ci-hdrc-usb2: add npcm750 and
 npcm845 compatible

On 05/10/2023 12:46, Tomer Maimon wrote:
> Hi Krzysztof,
> 
> Thanks for your comment
> 
> On Wed, 4 Oct 2023 at 11:03, Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 03/10/2023 13:01, Tomer Maimon wrote:
>>> Add a compatible string for Nuvoton BMC NPCM750 and Nuvoton BMC NPCM845.
>>>
>>> Signed-off-by: Tomer Maimon <tmaimon77@...il.com>
>>> ---
>>>  Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
>>> index 1394557517b1..a9e173432002 100644
>>> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
>>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
>>> @@ -16,6 +16,8 @@ properties:
>>>        - enum:
>>>            - chipidea,usb2
>>>            - lsi,zevio-usb
>>> +          - nuvoton,npcm750-udc
>>> +          - nuvoton,npcm845-udc
>>
>> Your driver clearly suggests these are compatible. If they are not, why
>> commit msg does no explain anything here?
> Do you mean to add nuvoton,npcmxxx-udc as described below to the end
> of the compatible property?
>       - items:
>           - enum:
>               - nuvoton,npcm845-udc
>           - const: nuvoton,npcm750-udc

For the 845 yes. Of course you also need enum entry for 750.

Best regards,
Krzysztof