linux-kernel - Re: Possible bug report: kernel 6.5.0/6.5.1 high load when CIFS share is mounted (cifsd-cfid-laundromat in"D" state)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85d538fec5a086acf62d5a803056586a6c00e4bd.camel@uniklinik-freiburg.de>
Date:   Thu, 5 Oct 2023 09:55:41 +0000
From:   "Dr. Bernd Feige" <bernd.feige@...klinik-freiburg.de>
To:     "tom@...pey.com" <tom@...pey.com>,
        "smfrench@...il.com" <smfrench@...il.com>,
        "paul@...krain42.org" <paul@...krain42.org>
CC:     "linux-cifs@...r.kernel.org" <linux-cifs@...r.kernel.org>,
        "bagasdotme@...il.com" <bagasdotme@...il.com>,
        "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>,
        "pc@...guebit.com" <pc@...guebit.com>,
        "ronniesahlberg@...il.com" <ronniesahlberg@...il.com>,
        "nspmangalore@...il.com" <nspmangalore@...il.com>,
        "brian.pardy@...il.com" <brian.pardy@...il.com>,
        "bharathsm@...rosoft.com" <bharathsm@...rosoft.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Possible bug report: kernel 6.5.0/6.5.1 high load when CIFS share
 is mounted (cifsd-cfid-laundromat in"D" state)

Am Dienstag, dem 26.09.2023 um 17:54 -0700 schrieb Paul Aurich:
> Perhaps the laundromat thread should be using msleep_interruptible()?
> 
> Using an interruptible sleep appears to prevent the thread from
> contributing 
> to the load average, and has the happy side-effect of removing the
> up-to-1s delay 
> when tearing down the tcon (since a7c01fa93ae, kthread_stop() will
> return 
> early triggered by kthread_stop).

Sorry for chiming in so late - I'm also on gentoo (kernel 6.5.5-
gentoo), but as a client of Windows AD.

Just want to emphasize that using uninterruptible sleep has not just
unhappy but devastating side-effects.

I have 8 processors and 16 cifsd-cfid-laundromat processes, so
/proc/loadavg reports a load average of 16 on a totally idle system.

This means that load-balancing software will never start additional
tasks on this system - "make -l" but also any other load-dependent
system. Just reducing the number of cifsd-cfid-laundromat processes
does not fix this - even a single one makes loadavg report a wrong
result for load balancing.

So, if cifsd-cfid-laundromat must really be uninterruptible, the only
solution would be to change the way loadavg is computed by the kernel
to exclude uninterruptible but sleeping processes. But must it be
uninterruptible?

Thanks and best regards,
Bernd