[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <888bde30-a61f-4b19-bb6f-0aec69f23415@isovalent.com>
Date: Thu, 5 Oct 2023 16:51:57 +0100
From: Quentin Monnet <quentin@...valent.com>
To: Ian Rogers <irogers@...gle.com>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Andrii Nakryiko <andrii@...nel.org>,
Martin KaFai Lau <martin.lau@...ux.dev>,
Song Liu <song@...nel.org>,
Yonghong Song <yonghong.song@...ux.dev>,
John Fastabend <john.fastabend@...il.com>,
KP Singh <kpsingh@...nel.org>,
Stanislav Fomichev <sdf@...gle.com>,
Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Alan Maguire <alan.maguire@...cle.com>
Subject: Re: [PATCH v4 1/2] bpftool: Align output skeleton ELF code
On 04/10/2023 23:23, Ian Rogers wrote:
> libbpf accesses the ELF data requiring at least 8 byte alignment,
> however, the data is generated into a C string that doesn't guarantee
> alignment. Fix this by assigning to an aligned char array. Use sizeof
> on the array, less one for the \0 terminator, rather than generating a
> constant.
>
> Fixes: a6cc6b34b93e ("bpftool: Provide a helper method for accessing skeleton's embedded ELF data")
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> Reviewed-by: Alan Maguire <alan.maguire@...cle.com>
Acked-by: Quentin Monnet <quentin@...valent.com>
Thanks
Powered by blists - more mailing lists