linux-kernel - Re: [PATCH net v1] octeontx2-pf: Fix page pool frag allocation failure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231005092145.08cc84fb@kernel.org>
Date:   Thu, 5 Oct 2023 09:21:45 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ratheesh Kannoth <rkannoth@...vell.com>
Cc:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <sgoutham@...vell.com>, <gakula@...vell.com>,
        <sbhatta@...vell.com>, <hkelam@...vell.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <pabeni@...hat.com>, <hawk@...nel.org>,
        <alexander.duyck@...il.com>, <ilias.apalodimas@...aro.org>,
        <linyunsheng@...wei.com>, <bigeasy@...utronix.de>
Subject: Re: [PATCH net v1] octeontx2-pf: Fix page pool frag allocation
 failure.

On Thu, 5 Oct 2023 07:44:34 +0530 Ratheesh Kannoth wrote:
> +	sz = PAGE_ALIGN(ALIGN(SKB_DATA_ALIGN(buf_size), OTX2_ALIGN));
> +	pp_params.order = get_order(sz);

Surely get_order() rounds up by itself otherwise all callers would
have to do the PAGE_ALIGN()...
-- 
pw-bot: cr