linux-kernel - Re: [PATCH] KEYS: trusted: Remove redundant static calls usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1570b53b991301ee73be185244ef43487bf5961.camel@linux.ibm.com>
Date:   Thu, 05 Oct 2023 12:45:06 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Sumit Garg <sumit.garg@...aro.org>, torvalds@...ux-foundation.org,
        jarkko@...nel.org, peterz@...radead.org
Cc:     linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
        jejb@...ux.ibm.com, David.Kaplan@....com, bp@...en8.de,
        mingo@...nel.org, x86@...nel.org, regressions@...mhuis.info,
        Hyeonggon Yoo <42.hyeyoo@...il.com>
Subject: Re: [PATCH] KEYS: trusted: Remove redundant static calls usage

Hi Summit,

On Thu, 2023-10-05 at 19:03 +0530, Sumit Garg wrote:
> Static calls invocations aren't well supported from module __init and
> __exit functions, especially the static call from cleanup_trusted() led 
> to a crash on x86 kernel with CONFIG_DEBUG_VIRTUAL=y.

Split the above paragraph into two sentences.

> However, the usage of static call invocations for trusted_key_init()
> and trusted_key_exit() doesn't adds any value neither from performance
> point and nor there is any security benefit.

   don't add any value from either a performance or security
perspective.

>  Hence switch to use indirect
> function calls instead.
> 
> Note here that although it will fix the current crash reported. But
> ultimately we need fix up static calls infrastructure to either support
> its future usage from module __init and __exit functions or not.

The first line is a sentence fragment.  Please replace the period with
a comma.

   report, ultimately the static call call infrastructure should ...

> 
> Reported-by: Hyeonggon Yoo <42.hyeyoo@...il.com>
> Closes: https://lore.kernel.org/lkml/ZRhKq6e5nF%2F4ZIV1@fedora/#t

Replace "Closes" with "Link".

> Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework")
> Signed-off-by: Sumit Garg <sumit.garg@...aro.org>

-- 
thanks,

Mimi