linux-kernel - Re: [RFC/RFT PATCH] gpiolib: reverse-assign the fwnode to struct gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaqPm9471q7Sg-cxcLTTE63=NuKuSUFiFtPsaUoRiB3jA@mail.gmail.com>
Date:   Sat, 7 Oct 2023 00:22:01 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Andy Shevchenko <andy@...nel.org>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Dipen Patel <dipenp@...dia.com>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [RFC/RFT PATCH] gpiolib: reverse-assign the fwnode to struct gpio_chip

On Fri, Oct 6, 2023 at 9:08 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:

> I don't see any good reason for it not having the fwnode assigned.
> User calling gpio_device_find() will have to jump through hoops in
> order to match the device by fwnode

Yeah I would add

struct fwnode_handle *gpiochip_get_fwnode(struct gpio_chip *gc)
{
   return dev_fwnode(&gc->gpiodev->dev);
}

so it's easy for external users to get the fwnode if they really need it.
This and a few more changes and we can drop gc->fwnode altogether
can't we?

Yours,
Linus Walleij