[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <00482b1c-c88d-4e84-ba06-92f00dec8f53@embeddedor.com>
Date: Fri, 6 Oct 2023 22:49:41 +0200
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: Kees Cook <keescook@...omium.org>,
Ping-Ke Shih <pkshih@...ltek.com>
Cc: Kalle Valo <kvalo@...nel.org>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>,
linux-wireless@...r.kernel.org, linux-hardening@...r.kernel.org,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org,
llvm@...ts.linux.dev
Subject: Re: [PATCH] wifi: rtw89: coex: Annotate struct
rtw89_btc_btf_set_slot_table with __counted_by
On 10/6/23 22:17, Kees Cook wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
> array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct
> rtw89_btc_btf_set_slot_table.
>
> Cc: Ping-Ke Shih <pkshih@...ltek.com>
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
> Cc: linux-wireless@...r.kernel.org
> Cc: linux-hardening@...r.kernel.org
> Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1]
> Signed-off-by: Kees Cook <keescook@...omium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>
Thanks!
--
Gustavo
> ---
> drivers/net/wireless/realtek/rtw89/coex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/coex.c b/drivers/net/wireless/realtek/rtw89/coex.c
> index 4ba8b3df70ae..d66a1152c3f5 100644
> --- a/drivers/net/wireless/realtek/rtw89/coex.c
> +++ b/drivers/net/wireless/realtek/rtw89/coex.c
> @@ -237,7 +237,7 @@ struct rtw89_btc_btf_set_report {
> struct rtw89_btc_btf_set_slot_table {
> u8 fver;
> u8 tbl_num;
> - u8 buf[];
> + u8 buf[] __counted_by(tbl_num);
> } __packed;
>
> struct rtw89_btc_btf_set_mon_reg {
Powered by blists - more mailing lists