linux-kernel - Re: [RFC PATCH] ARM: dts: at91: sama5d3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <070a6f48-20a4-4e26-a071-0600a6ecea36@tuxon.dev>
Date:   Fri, 6 Oct 2023 11:15:49 +0300
From:   claudiu beznea <claudiu.beznea@...on.dev>
To:     nicolas.ferre@...rochip.com, linux-arm-kernel@...ts.infradead.org,
        jerry.ray@...rochip.com
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] ARM: dts: at91: sama5d3_eds: remove TDES use

Hi, Nicolas, Jerry,

On 28.09.2023 17:56, nicolas.ferre@...rochip.com wrote:
> From: Nicolas Ferre <nicolas.ferre@...rochip.com>
> 
> TDES doesn't probe because of lack of DMA channels left on this
> controller. As we don't need TDES HW engine, we prefer to keep DMA
> channels for other usage.
> Disable TDES for this board.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
> ---
> Hi,
> 
> Tell me what you think about this move. I think it makes sense but tell me if
> application could suffer from this lack of TDES engine.

It anyway fails to probe. I have nothing against unless its probing could
be fixed. Jerry, are you good with applying this?

Thank you,
Claudiu Beznea

> 
> Regards,
>   Nicolas
> 
>  arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> index c287b03d768b..fddd786f8483 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sama5d3_eds.dts
> @@ -284,6 +284,10 @@ timer1: timer@1 {
>  	};
>  };
>  
> +&tdes {
> +	status = "disabled";
> +};
> +
>  &usb0 {	/* USB Device port with VBUS detection. */
>  	atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>;
>  	pinctrl-names = "default";