linux-kernel - Re: [PATCH] mips: dts: ralink: mt7621: define each reset as an item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZR/Dtm0wTCa/V26h@alpha.franken.de>
Date:   Fri, 6 Oct 2023 10:22:14 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Arınç ÜNAL <arinc.unal@...nc9.com>
Cc:     Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] mips: dts: ralink: mt7621: define each reset as an item

On Sun, Sep 17, 2023 at 01:37:53PM +0300, Arınç ÜNAL wrote:
> Each item of the resets property should define a reset. Split the item with
> two resets on the ethernet node into two separate items.
> 
> Sort the items of the clocks property to the same line as a trivial change.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> ---
>  arch/mips/boot/dts/ralink/mt7621.dtsi | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index 7caed0d14f11..35a10258f235 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -300,14 +300,13 @@ ethernet: ethernet@...00000 {
>  		compatible = "mediatek,mt7621-eth";
>  		reg = <0x1e100000 0x10000>;
>  
> -		clocks = <&sysc MT7621_CLK_FE>,
> -			 <&sysc MT7621_CLK_ETH>;
> +		clocks = <&sysc MT7621_CLK_FE>, <&sysc MT7621_CLK_ETH>;
>  		clock-names = "fe", "ethif";
>  
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		resets = <&sysc MT7621_RST_FE &sysc MT7621_RST_ETH>;
> +		resets = <&sysc MT7621_RST_FE>, <&sysc MT7621_RST_ETH>;
>  		reset-names = "fe", "eth";
>  
>  		interrupt-parent = <&gic>;
> -- 
> 2.39.2
> 

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]