linux-kernel - Re: [PATCH] sound: fix name of SIS7013 sound chip in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ttr4w2vh.wl-tiwai@suse.de>
Date:   Fri, 06 Oct 2023 10:50:58 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Thomas Perl <m@....io>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "trivial@...nel.org" <trivial@...nel.org>
Subject: Re: [PATCH] sound: fix name of SIS7013 sound chip in comment

On Wed, 27 Sep 2023 09:17:32 +0200,
Thomas Perl wrote:
> 
> While grep'ing for SIS7012, I noticed that there is
> only one reference to it in sound/pci/intel8x0m.c,
> while most of its code lives in sound/pci/intel8x0.c.
> 
> This probably was a simple copy'n'paste mistake, as
> the sound/pci/intel8x0m.c driver implements support
> for SIS7013 (see DEVICE_SIS), and the two devices
> seem to share the same behavior / registers.
> 
> Signed-off-by: Thomas Perl <m@....io>

Thanks for the patch.

Unfortunately the patch isn't applicable cleanly, likely due to your
mailer malformed the spaces.  As it's a really trivial change, I fixed
manually now.  But, at the next time, please try to fix your mailer
setup and at best test the patch application by yourself beforehand.


Takashi



> ---
>  sound/pci/intel8x0m.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/intel8x0m.c b/sound/pci/intel8x0m.c
> index 2845cc006d0c..653ecca78238 100644
> --- a/sound/pci/intel8x0m.c
> +++ b/sound/pci/intel8x0m.c
> @@ -918,7 +918,7 @@ static int snd_intel8x0m_ich_chip_init(struct intel8x0m *chip, int probing)
>   }
>     if (chip->device_type == DEVICE_SIS) {
> - /* unmute the output on SIS7012 */
> + /* unmute the output on SIS7013 */
>   iputword(chip, 0x4c, igetword(chip, 0x4c) | 1);
>   }
>   --  2.39.2
>