linux-kernel - [PATCH] soc: samsung: usi: remove superfluous parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231006090014.277448-1-tudor.ambarus@linaro.org>
Date:   Fri,  6 Oct 2023 10:00:14 +0100
From:   Tudor Ambarus <tudor.ambarus@...aro.org>
To:     krzysztof.kozlowski@...aro.org, alim.akhtar@...sung.com
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        semen.protsenko@...aro.org, peter.griffin@...aro.org,
        Tudor Ambarus <tudor.ambarus@...aro.org>
Subject: [PATCH] soc: samsung: usi: remove superfluous parameter

exynos_usi_set_sw_conf() has a single caller, exynos_usi_configure,
which called it with exynos_usi_set_sw_conf(usi, usi->mode). Since the
mode is already defined in struct exynos_usi, remove the superfluous
pass of the mode parameter. While in exynos_usi_set_sw_conf(), remove the
reinitialization of usi->mode with its same value.

Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>
---
 drivers/soc/samsung/exynos-usi.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/soc/samsung/exynos-usi.c b/drivers/soc/samsung/exynos-usi.c
index 114352695ac2..269ed930c5a9 100644
--- a/drivers/soc/samsung/exynos-usi.c
+++ b/drivers/soc/samsung/exynos-usi.c
@@ -95,14 +95,14 @@ MODULE_DEVICE_TABLE(of, exynos_usi_dt_match);
 /**
  * exynos_usi_set_sw_conf - Set USI block configuration mode
  * @usi: USI driver object
- * @mode: Mode index
  *
  * Select underlying serial protocol (UART/SPI/I2C) in USI IP-core.
  *
  * Return: 0 on success, or negative error code on failure.
  */
-static int exynos_usi_set_sw_conf(struct exynos_usi *usi, size_t mode)
+static int exynos_usi_set_sw_conf(struct exynos_usi *usi)
 {
+	size_t mode = usi->mode;
 	unsigned int val;
 	int ret;
 
@@ -115,8 +115,7 @@ static int exynos_usi_set_sw_conf(struct exynos_usi *usi, size_t mode)
 	if (ret)
 		return ret;
 
-	usi->mode = mode;
-	dev_dbg(usi->dev, "protocol: %s\n", exynos_usi_modes[usi->mode].name);
+	dev_dbg(usi->dev, "protocol: %s\n", exynos_usi_modes[mode].name);
 
 	return 0;
 }
@@ -164,7 +163,7 @@ static int exynos_usi_configure(struct exynos_usi *usi)
 {
 	int ret;
 
-	ret = exynos_usi_set_sw_conf(usi, usi->mode);
+	ret = exynos_usi_set_sw_conf(usi);
 	if (ret)
 		return ret;
 
-- 
2.42.0.609.gbb76f46606-goog