linux-kernel - Re: [PATCH v1] ALSA: hda: cs35l41: Cleanup and fix double free in firmware request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mswww25y.wl-tiwai@suse.de>
Date:   Fri, 06 Oct 2023 11:06:17 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Stefan Binding <sbinding@...nsource.cirrus.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        <patches@...nsource.cirrus.com>, kernel test robot <lkp@...el.com>,
        "Dan Carpenter" <dan.carpenter@...aro.org>
Subject: Re: [PATCH v1] ALSA: hda: cs35l41: Cleanup and fix double free in firmware request

On Tue, 03 Oct 2023 16:21:38 +0200,
Stefan Binding wrote:
> 
> There is an unlikely but possible double free when loading firmware,
> and a missing free calls if a firmware is successfully requested but
> the coefficient file request fails, leading to the fallback firmware
> request occurring without clearing the previously loaded firmware.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/r/202309291331.0JUUQnPT-lkp@intel.com/
> 
> Signed-off-by: Stefan Binding <sbinding@...nsource.cirrus.com>

Applied now (with additional Fixes tag).
At the next time, please try to put the Fixes tag for a fix like
this.


thanks,

Takashi