linux-kernel - Re: [PATCH v7 20/23] drm/mediatek: Remove the redundant driver data for DPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec4bae581ac120276cc041d82203ff07a48d5c2f.camel@mediatek.com>
Date:   Fri, 6 Oct 2023 09:11:07 +0000
From:   CK Hu (胡俊光) <ck.hu@...iatek.com>
To:     Shawn Sung (宋孝謙) 
        <Shawn.Sung@...iatek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Singo Chang (張興國) 
        <Singo.Chang@...iatek.com>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Jason-JH Lin (林睿祥) 
        <Jason-JH.Lin@...iatek.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "airlied@...il.com" <airlied@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v7 20/23] drm/mediatek: Remove the redundant driver data
 for DPI

Hi, Hsiao-chien:

On Fri, 2023-10-06 at 15:38 +0800, Hsiao Chien Sung wrote:
> DPI input is in 1T2P mode on both MT8195 and MT8188.
> Remove the redundant driver data to align the settings, or
> the screen will glitch.

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Fixes: 2847cd7e6403 ("drm/mediatek: Add mt8188 dpi compatibles and
> platform data")
> 
> Signed-off-by: Hsiao Chien Sung <shawn.sung@...iatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dpi.c | 16 +---------------
>  1 file changed, 1 insertion(+), 15 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 2f931e4e2b60..bc073a6b367e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -957,20 +957,6 @@ static const struct mtk_dpi_conf mt8186_conf = {
>  	.csc_enable_bit = CSC_ENABLE,
>  };
>  
> -static const struct mtk_dpi_conf mt8188_dpintf_conf = {
> -	.cal_factor = mt8195_dpintf_calculate_factor,
> -	.max_clock_khz = 600000,
> -	.output_fmts = mt8195_output_fmts,
> -	.num_output_fmts = ARRAY_SIZE(mt8195_output_fmts),
> -	.pixels_per_iter = 4,
> -	.input_2pixel = false,
> -	.dimension_mask = DPINTF_HPW_MASK,
> -	.hvsize_mask = DPINTF_HSIZE_MASK,
> -	.channel_swap_shift = DPINTF_CH_SWAP,
> -	.yuv422_en_bit = DPINTF_YUV422_EN,
> -	.csc_enable_bit = DPINTF_CSC_ENABLE,
> -};
> -
>  static const struct mtk_dpi_conf mt8192_conf = {
>  	.cal_factor = mt8183_calculate_factor,
>  	.reg_h_fre_con = 0xe0,
> @@ -1094,7 +1080,7 @@ static const struct of_device_id
> mtk_dpi_of_ids[] = {
>  	{ .compatible = "mediatek,mt8173-dpi", .data = &mt8173_conf },
>  	{ .compatible = "mediatek,mt8183-dpi", .data = &mt8183_conf },
>  	{ .compatible = "mediatek,mt8186-dpi", .data = &mt8186_conf },
> -	{ .compatible = "mediatek,mt8188-dp-intf", .data =
> &mt8188_dpintf_conf },
> +	{ .compatible = "mediatek,mt8188-dp-intf", .data =
> &mt8195_dpintf_conf },
>  	{ .compatible = "mediatek,mt8192-dpi", .data = &mt8192_conf },
>  	{ .compatible = "mediatek,mt8195-dp-intf", .data =
> &mt8195_dpintf_conf },
>  	{ /* sentinel */ },