linux-kernel - Re: [PATCH v4 2/2] i2c: muxes: pca954x: Enable features on MAX7357

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79fd231f-c43a-bcbb-9660-c58e5bfbd953@axentia.se>
Date:   Fri, 6 Oct 2023 12:32:26 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Naresh Solanki <naresh.solanki@...ements.com>
Cc:     Patrick Rudolph <patrick.rudolph@...ements.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] i2c: muxes: pca954x: Enable features on MAX7357

Hi again!

[sorry for replying to self]

2023-10-06 at 09:46, Peter Rosin wrote:
> 2023-10-05 at 15:45, Naresh Solanki wrote:
>> From: Patrick Rudolph <patrick.rudolph@...ements.com>
>>

...

>> +			dev_warn(&client->dev,
>> +				 "Write byte not supported. Cannot enable enhanced mode features");
> 
> Missing \n at the end of the string.
> 

Also, I2C_FUNC_SMBUS_WRITE_BYTE is separate from
I2C_FUNC_SMBUS_WRITE_BYTE_DATA, which makes that "Write byte"
misleading.

Cheers,
Peter