linux-kernel - Re: [PATCH 09/11] MIPS: mobileye: Add EPM5 device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <37d3c19a-4106-45f9-ae2a-99bf41a8bab0@app.fastmail.com>
Date:   Fri, 06 Oct 2023 13:18:00 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Gregory Clement" <gregory.clement@...tlin.com>,
        "Paul Burton" <paulburton@...nel.org>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        linux-mips@...r.kernel.org, "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     "Vladimir Kondratiev" <vladimir.kondratiev@...el.com>,
        "Tawfik Bayouk" <tawfik.bayouk@...ileye.com>,
        "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
        Théo Lebrun <theo.lebrun@...tlin.com>,
        "Thomas Petazzoni" <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 09/11] MIPS: mobileye: Add EPM5 device tree

On Wed, Oct 4, 2023, at 18:10, Gregory CLEMENT wrote:
> +
> +	chosen {
> +		bootargs = "cca=5 earlycon console=ttyAMA2 ddr32_alias=0x40000000";
> +		stdout-path = "serial2:115200n8";
> +	};
> +

The bootargs should not be needed here, at least most of them:

- no need to set both console= and the stdout-path if you have
  earlycon support

- ddr32_alias=0x40000000 sounds like something that should be
  part of the dtb elsewhere and not require a command line argument.
  I assume this is needed to even build?

- For cca=, it looks like this is intended to be autodetected from
  the c0_config register. Does that not work for you for some reason?

     Arnd