linux-kernel - Re: [PATCH] video: fbdev: arkfb: fix possible object reference leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_B2B6C2C0E43CB415F6506B24B66ED26BB909@qq.com>
Date:   Fri, 6 Oct 2023 19:19:24 +0800
From:   Zhang Shurong <zhang_shurong@...mail.com>
To:     Helge Deller <deller@....de>
Cc:     tzimmermann@...e.de, jiapeng.chong@...ux.alibaba.com,
        javierm@...hat.com, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: arkfb: fix possible object reference leak

Since the graphic card in question is quite old, I haven't had the 
opportunity
to personally test it yet.

I decided to send the patch because, upon careful consideration,
I couldn't find any compelling reasons not to include the call to
pci_disable_device(). However, I completely understand your point,
and I agree that if there is no definitive explanation for why
it should be ignored, it would be prudent to locate the actual hardware
and conduct proper testing.

I genuinely appreciate your thorough review and valuable feedback on
this matter. Maybe I will find this old card and test this patch.


Thank you and best regards,

Shurong

On 2023/10/6 16:09, Helge Deller wrote:
> On 10/5/23 09:01, Zhang Shurong wrote:
>> Add missing pci_disable_device() in error path in ark_pci_probe().
>
> Do you have this hardware and tested your patch?
> I'm sure there is a reason, why "pci_disable_device()" was commented
> out in the original submission in commit 681e14730c73c...
>
> Additionally I'm wondering why your patch doesn't show up in
> the fbdev patchwork, although you added linux-fbdev mailing list.
> Probably a vger issue.
>
> Helge
>
>
>> Signed-off-by: Zhang Shurong <zhang_shurong@...mail.com>
>> ---
>>   drivers/video/fbdev/arkfb.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
>> index 60a96fdb5dd8..6c4e5065646f 100644
>> --- a/drivers/video/fbdev/arkfb.c
>> +++ b/drivers/video/fbdev/arkfb.c
>> @@ -1064,7 +1064,7 @@ static int ark_pci_probe(struct pci_dev *dev, 
>> const struct pci_device_id *id)
>>   err_dac:
>>       pci_release_regions(dev);
>>   err_request_regions:
>> -/*    pci_disable_device(dev); */
>> +    pci_disable_device(dev);
>>   err_enable_device:
>>       framebuffer_release(info);
>>       return rc;
>> @@ -1085,7 +1085,7 @@ static void ark_pci_remove(struct pci_dev *dev)
>>
>>           pci_iounmap(dev, info->screen_base);
>>           pci_release_regions(dev);
>> -/*        pci_disable_device(dev); */
>> +        pci_disable_device(dev);
>>
>>           framebuffer_release(info);
>>       }
>