linux-kernel - Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on Lenovo Yoga Slim 7 Pro 14ARH7 82UU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62e54bf9-18fe-41cb-86d4-20f24074d267@leemhuis.info>
Date:   Fri, 6 Oct 2023 13:59:21 +0200
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@...mhuis.info>
To:     Markus Meier <kerneldev@...c-bytes.net>,
        alsa-devel@...a-project.org,
        Linux regressions mailing list <regressions@...ts.linux.dev>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Mario Limonciello <mario.limonciello@....com>,
        Mark Brown <broonie@...nel.org>,
        Sven Frotscher <sven.frotscher@...il.com>,
        August Wikerfors <git@...ustwikerfors.se>
Subject: Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on Lenovo Yoga Slim
 7 Pro 14ARH7 82UU

On 03.10.23 17:04, Markus Meier wrote:
> Am Dienstag, 3. Oktober 2023, 12:24:56 CEST schrieben Sie:
>> On 02.10.23 23:04, Markus Meier wrote:
>>> I own a  Lenovo Yoga Slim 7 Pro 14ARH7 where the microphone is not showing
>>> up. I added the system to the quirk table and the mic is working
>>> correctly (but with very low volume) now.
> [...]
>> I CCed a bunch of lists and people to make sure everyone is aware of
>> that patch, as it otherwise might fall through the cracks.
>>
>> Markus, quick question: do you have (a) an interest in contributing a
>> change to Linux or (b) did you just post this because Mario asked you to
>> do so in https://bugzilla.kernel.org/show_bug.cgi?id=217063#c25 ?
> 
> Nope I don't plan to become some kind of kernel developer. I just want to use 
> my notebook without any issues and want to help others who want to use this 
> device with Linux too. I just followed Mario's suggestions. I thought it would 
> be easier for everyone when I create a patch, try if it works and then submit 
> it to a bugtracker to get the bug fixed.

And that's good, as that way we know that the fix works, so many thx for
it. It's just that the patch description needs to be more like the
following.

"""
The 82UU (Lenovo Yoga Slim 7 Pro 14ARH7) requires an entry in the quirk
list to enable the internal microphone, just like many other Lenovo 82*
devices recently added.

Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo
82SJ")
Cc: stable@...r.kernel.org
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217063#c23
"""

Add another line right below with your sign-off, as explained here:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Then send it again. The patch likely must be inline (but maybe Mark
accepts attached patches as well, not sure, some maintainers do).

If you want the easy way out, just reply to your mail that started this
thread (with me in CC) with a signed-off-by tag for the patch, then I'll
handle the rest.

> [...]
> Thanks for your help Thorsten. I really enjoyed your Heise Kernel-Log series 
> and I really miss those series. Was always a pleasure to read that.

Thx, great to hear!

Ciao, Thorsten