lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3cbd358e-501a-217f-6482-e20b55e7c728@redhat.com>
Date:   Fri, 6 Oct 2023 14:18:11 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Matthew Wilcox <willy@...radead.org>,
        Muzammil <m.muzzammilashraf@...il.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: rmap.c: fix kenrel-doc warning

On 06.10.23 14:16, Matthew Wilcox wrote:
> On Fri, Oct 06, 2023 at 04:39:48PM +0500, Muzammil wrote:
>>   /**
>>    * folio_move_anon_rmap - move a folio to our anon_vma
>> - * @page:	The folio to move to our anon_vma
>> + * @folio:  struct folio - Represents a contiguous set of bytes.
>>    * @vma:	The vma the folio belongs to
> 
> Why did you change more than just 'page' to 'folio'?  I think the
> other changes you have made to this line are not an improvement.

Oh, I missed that. indeed, just s/page/folio/ is sufficient.

-- 
Cheers,

David / dhildenb

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ