[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4131ade7-c790-053c-99cb-3544f3c6523d@redhat.com>
Date: Fri, 6 Oct 2023 14:57:35 +0200
From: David Hildenbrand <david@...hat.com>
To: Lorenzo Stoakes <lstoakes@...il.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Ian Rogers <irogers@...gle.com>,
Adrian Hunter <adrian.hunter@...el.com>,
Oleg Nesterov <oleg@...hat.com>,
Richard Cochran <richardcochran@...il.com>,
Jason Gunthorpe <jgg@...dia.com>,
John Hubbard <jhubbard@...dia.com>,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2 4/4] mm/gup: adapt get_user_page_vma_remote() to never
return NULL
On 03.10.23 01:14, Lorenzo Stoakes wrote:
> get_user_pages_remote() will never return 0 except in the case of
> FOLL_NOWAIT being specified, which we explicitly disallow.
>
> This simplifies error handling for the caller and avoids the awkwardness of
> dealing with both errors and failing to pin. Failing to pin here is an
> error.
>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Catalin Marinas <catalin.marinas@....com>
> Signed-off-by: Lorenzo Stoakes <lstoakes@...il.com>
> ---
Reviewed-by: David Hildenbrand <david@...hat.com>
--
Cheers,
David / dhildenb
Powered by blists - more mailing lists