linux-kernel - Re: [PATCH v3 5/8] thermal: exynos: simplify regulator (de)initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Oct 2023 15:15:50 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Mateusz Majewski <m.majewski2@...sung.com>,
        linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v3 5/8] thermal: exynos: simplify regulator
 (de)initialization

On 03/10/2023 13:16, Mateusz Majewski wrote:
> We rewrite the initialization to enable the regulator as part of devm,
> which allows us to not handle the struct instance manually. We also
> remove the error message in case the regulator is unavailable, as this
> is expected behaviour.
> 
> Signed-off-by: Mateusz Majewski <m.majewski2@...sung.com>
> ---
> v2 -> v3: fixed error handling of devm_regulator_get_optional to handle
>   the case in which the regulator is available, but enabling it fails.
>   Also removed the error message, split into two commits and reworded
>   the commit message.
> 

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof