linux-kernel - RE: [PATCH] fpga: versal: Add support for 44-bit DMA operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN0PR12MB595373EEE62FDFD58025B93EB7C9A@MN0PR12MB5953.namprd12.prod.outlook.com>
Date:   Fri, 6 Oct 2023 02:54:02 +0000
From:   "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
To:     "Manne, Nava kishore" <nava.kishore.manne@....com>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "hao.wu@...el.com" <hao.wu@...el.com>,
        "yilun.xu@...el.com" <yilun.xu@...el.com>,
        "trix@...hat.com" <trix@...hat.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Simek, Michal" <michal.simek@....com>
Subject: RE: [PATCH] fpga: versal: Add support for 44-bit DMA operations

> -----Original Message-----
> From: Manne, Nava kishore <nava.kishore.manne@....com>
> Sent: Tuesday, October 3, 2023 12:44 PM
> To: mdf@...nel.org; hao.wu@...el.com; yilun.xu@...el.com;
> trix@...hat.com; linux-fpga@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Pandey, Radhey Shyam <radhey.shyam.pandey@....com>
> Subject: [PATCH] fpga: versal: Add support for 44-bit DMA operations
> 
> The existing implementation support only 32-bit DMA operation.
> So, it fails to load the bitstream for the high DDR designs(Beyond 4GB).
> To fix this issue update the DMA mask handling logic to support 44-bit DMA
> operations.
> 
> Signed-off-by: Nava kishore Manne <nava.kishore.manne@....com>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
As I reviewed it on internal list - adding my reviewed tag here as well.
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>
Thanks!
> ---
>  drivers/fpga/versal-fpga.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/versal-fpga.c b/drivers/fpga/versal-fpga.c index
> e1601b3a345b..3710e8f01be2 100644
> --- a/drivers/fpga/versal-fpga.c
> +++ b/drivers/fpga/versal-fpga.c
> @@ -48,7 +48,7 @@ static int versal_fpga_probe(struct platform_device
> *pdev)
>  	struct fpga_manager *mgr;
>  	int ret;
> 
> -	ret = dma_set_mask_and_coherent(&pdev->dev,
> DMA_BIT_MASK(32));
> +	ret = dma_set_mask_and_coherent(&pdev->dev,
> DMA_BIT_MASK(44));
>  	if (ret < 0) {
>  		dev_err(dev, "no usable DMA configuration\n");
>  		return ret;
> --
> 2.25.1