[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231006155351.3503665-1-andriy.shevchenko@linux.intel.com>
Date: Fri, 6 Oct 2023 18:53:51 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
acpi4asus-user@...ts.sourceforge.net,
platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: João Paulo Rechi Vita <jprvita@...il.com>,
Corentin Chary <corentin.chary@...il.com>,
Hans de Goede <hdegoede@...hat.com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
Mark Gross <markgross@...nel.org>
Subject: [PATCH v3 1/1] platform/x86: asus-wireless: Replace open coded acpi_match_device()
Replace open coded acpi_match_device() in asus_wireless_add().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
---
v3: rewrote error path logic (Hans)
v2: fixed compilation error
drivers/platform/x86/asus-wireless.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index abf01e00b799..1a571efa02eb 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -148,16 +148,12 @@ static int asus_wireless_add(struct acpi_device *adev)
if (err)
return err;
- for (id = device_ids; id->id[0]; id++) {
- if (!strcmp((char *) id->id, acpi_device_hid(adev))) {
- data->hswc_params =
- (const struct hswc_params *)id->driver_data;
- break;
- }
- }
- if (!data->hswc_params)
+ id = acpi_match_device(device_ids, adev);
+ if (!id)
return 0;
+ data->hswc_params = (const struct hswc_params *)id->driver_data;
+
data->wq = create_singlethread_workqueue("asus_wireless_workqueue");
if (!data->wq)
return -ENOMEM;
--
2.40.0.1.gaa8946217a0b
Powered by blists - more mailing lists