linux-kernel - Re: [PATCH 1/2] dt-bindings: zynqmp: add destination mailbox compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Oct 2023 12:53:48 -0500
From:   Rob Herring <robh@...nel.org>
To:     Tanmay Shah <tanmay.shah@....com>
Cc:     jassisinghbrar@...il.com, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, michal.simek@....com,
        shubhrajyoti.datta@....com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: zynqmp: add destination mailbox
 compatible

On Thu, Oct 05, 2023 at 10:08:24AM -0700, Tanmay Shah wrote:
> Current dt-bindings does not contain compatible property
> for child mailbox node. Child mailbox nodes are used
> to represent destination (remote) IPI agents. The compatible
> property for all destination mailboxes must be required.
> 
> Signed-off-by: Tanmay Shah <tanmay.shah@....com>
> ---
>  .../bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml           | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
> index aeaddbf574b0..8b15a0532120 100644
> --- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.yaml
> @@ -74,6 +74,10 @@ patternProperties:
>      type: object  # DT nodes are json objects
>      additionalProperties: false
>      properties:
> +
> +      compatible:
> +        const: xlnx,zynqmp-ipi-dest-mailbox
> +
>        xlnx,ipi-id:
>          description:
>            Remote Xilinx IPI agent ID of which the mailbox is connected to.
> @@ -95,6 +99,7 @@ patternProperties:
>            - const: remote_response_region
>  
>      required:
> +      - compatible

A new required property is an ABI break, but nothing about that in the 
commit msg.

>        - reg
>        - reg-names
>        - "#mbox-cells"
> @@ -124,6 +129,7 @@ examples:
>          ranges;
>  
>          mailbox: mailbox@...905c0 {
> +          compatible = "xlnx,zynqmp-ipi-dest-mailbox";
>            reg = <0x0 0xff9905c0 0x0 0x20>,
>                  <0x0 0xff9905e0 0x0 0x20>,
>                  <0x0 0xff990e80 0x0 0x20>,
> 
> base-commit: 7d730f1bf6f39ece2d9f3ae682f12e5b593d534d
> -- 
> 2.25.1
>