[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <169661501435.70432.16755877986670034633.robh@kernel.org>
Date: Fri, 6 Oct 2023 12:56:54 -0500
From: Rob Herring <robh@...nel.org>
To: Martin Kaiser <martin@...ser.cx>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
linux-arm-kernel@...ts.infradead.org,
Conor Dooley <conor+dt@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Magnus Damm <magnus.damm@...il.com>,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] dt-bindings: pinctrl: st,stm32: fix phandle-array warning
On Fri, 06 Oct 2023 10:22:48 +0200, Martin Kaiser wrote:
> make CHECK_DTBS=y st/stm32f469-disco.dtb
>
> brings up a warning about a missing argument:
>
> stm32f469-disco.dtb: pinctrl@...20000: st,syscfg:0: [21, 8] is too short
>
> The description of the third entry indicates that this entry is optional.
> The code in stm32_pctrl_dt_setup_irq parses st,syscfg and treats the third
> entry as optional. It defaults to 0xf if not present in the devicetree.
>
> Update the schema to require at least two entries, use the same syntax as
> the description of renesas,ipmmu-main in
> Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml.
>
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>
> I tested the following cases, all of them returned the expected result:
>
> st,syscfg = <&syscfg>; (too short)
> st,syscfg = <&syscfg 0x8>; (ok)
> st,syscfg = <&syscfg 0x8 0x0>; (ok)
> st,syscfg = <&syscfg 0x8 0x0 0x0>; (too long)
>
> .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists