[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VeWwzg1spSvQ1tNmC7zVN1FLOjcpRGZsoL-49Di02pn0g@mail.gmail.com>
Date: Fri, 6 Oct 2023 20:59:46 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Dmitry Rokosov <ddrokosov@...utedevices.com>
Cc: lee@...nel.org, pavel@....cz, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
kernel@...rdevices.ru, rockosov@...il.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org,
George Stark <gnstark@...utedevices.com>
Subject: Re: [PATCH v1 05/11] leds: aw200xx: calculate dts property
display_rows in driver
On Fri, Oct 6, 2023 at 7:05 PM Dmitry Rokosov
<ddrokosov@...utedevices.com> wrote:
>
> From: George Stark <gnstark@...utedevices.com>
>
> Get rid of device tree property "awinic,display-rows" and calculate it
> in driver using led definition nodes. display-row actually means number
> of current switches and depends on how leds are connected to the device.
So, how do we know that there will be no regressions on the systems
where this property is used in production?
...
> + if (max_source < source)
> + max_source = source;
max() (will need minmax.h)?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists