linux-kernel - Re: [PATCH 1/2] ALSA: aloop: Add support for the non-interleaved access mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Oct 2023 19:06:38 +0100
From:   Ivan Orlov <ivan.orlov0322@...il.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ALSA: aloop: Add support for the non-interleaved
 access mode

On 10/6/23 09:52, Takashi Iwai wrote:
> On Wed, 27 Sep 2023 13:35:54 +0200,
> Ivan Orlov wrote:
>>
>> The current version of the loopback driver supports interleaved access
>> mode only. This patch introduces support for the non-interleaved
>> access mode.
>>
>> When in the interleaved mode, the 'copy_play_buf' function copies data
>> from the playback to the capture buffer using one memcpy call. This call
>> copies samples for multiple, interleaved channels.
>>
>> In the non-interleaved mode we have multiple channel buffers, so we have
>> to perform multiple memcpy calls to copy samples channel after channel.
>>
>> Add new function called 'copy_play_buf_part_n', which copies a part of
>> each channel buffer from playback to capture. Modify the 'copy_play_buf'
>> to use the corresponding memory copy function(just memcpy /
>> copy_play_buf_part_n) depending on the access mode.
>>
>> Signed-off-by: Ivan Orlov <ivan.orlov0322@...il.com>
> 
> Sorry for the late reaction, as I've been (still) off since the last
> week.
> 
> Now applied both patches.  Thanks.
> 

Hi Takashi,

No worries and thank you for applying both patches :)

--
Kind regards,
Ivan Orlov