[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231006193609.GA865463@bhelgaas>
Date: Fri, 6 Oct 2023 14:36:09 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Liu Song <liusong@...ux.alibaba.com>
Cc: bhelgaas@...gle.com, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH] PCI: eliminate abnormal characters when reads help
information of "PCI_P2PDMA" under menuconfig
On Wed, Jul 20, 2022 at 03:22:03PM +0800, Liu Song wrote:
> From: Liu Song <liusong@...ux.alibaba.com>
>
> Read the help information of PCI_P2PDMA through make menuconfig,
> "Enables" is partially displayed as garbled characters, so fix it.
>
> Signed-off-by: Liu Song <liusong@...ux.alibaba.com>
I think I derailed this by suggesting that we fix other Kconfig files
at the same time, which ended up with a cross-subsystem patch that
nobody picked up. My fault, sorry.
So I applied this now to pci/misc for v6.7, thank you!
Uwe just posted an identical patch, so I updated the commit log to
mention his patch as well:
PCI: Replace unnecessary UTF-8 in Kconfig
The CONFIG_PCI_P2PDMA Kconfig help text contains a Cyrillic small "Dze"
(ѕ). When menuconfig renders it, it looks like "Enable ~U drivers" instead
of "Enables drivers".
Replace it by a plain "s" so the help text is displayed correctly by
menuconfig.
Uwe Kleine-König <u.kleine-koenig@...gutronix.de> later posted the same
patch at
https://lore.kernel.org/r/20231006150209.87666-1-u.kleine-koenig@pengutronix.de
> ---
> drivers/pci/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 133c732..8102b78 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -166,7 +166,7 @@ config PCI_P2PDMA
> depends on ZONE_DEVICE
> select GENERIC_ALLOCATOR
> help
> - Enableѕ drivers to do PCI peer-to-peer transactions to and from
> + Enables drivers to do PCI peer-to-peer transactions to and from
> BARs that are exposed in other devices that are the part of
> the hierarchy where peer-to-peer DMA is guaranteed by the PCI
> specification to work (ie. anything below a single PCI bridge).
> --
> 1.8.3.1
>
Powered by blists - more mailing lists