linux-kernel - Re: [PATCH v2 1/1] platform/x86: xo15-ebook: Replace open coded acpi_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZSEISNzKdNIs7WHy@smile.fi.intel.com>
Date:   Sat, 7 Oct 2023 10:27:04 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Mark Gross <markgross@...nel.org>
Subject: Re: [PATCH v2 1/1] platform/x86: xo15-ebook: Replace open coded
 acpi_match_device()

On Fri, Oct 06, 2023 at 05:34:19PM +0200, Hans de Goede wrote:
> On 10/6/23 17:31, Andy Shevchenko wrote:

...
`
> Thanks, patch looks good to me:
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Same issue as with other patch...

...

> > +	id = acpi_match_device(ebook_device_ids, device);

Should be acpi_match_acpi_device().

> > +	if (!id) {
> > +		dev_err(&device->dev, "Unsupported hid\n");
> >  		error = -ENODEV;
> >  		goto err_free_input;
> >  	}

-- 
With Best Regards,
Andy Shevchenko