[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fa567e0b-00ca-76ad-f9e7-a554714f813c@huawei.com>
Date: Sat, 7 Oct 2023 17:45:32 +0800
From: Wenchao Hao <haowenchao2@...wei.com>
To: <dgilbert@...erlog.com>,
"James E . J . Bottomley" <jejb@...ux.ibm.com>,
"Martin K . Petersen" <martin.petersen@...cle.com>,
<open-iscsi@...glegroups.com>, <linux-scsi@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, <louhongxiang@...wei.com>
Subject: Re: [PATCH v5 08/10] scsi: scsi_debug: Add new error injection reset
lun failed
On 2023/10/7 5:04, Douglas Gilbert wrote:
> On 2023-09-22 05:29, Wenchao Hao wrote:
>> Add error injection type 3 to make scsi_debug_device_reset() return FAILED.
>> Fail abort command foramt:
>
> s/foramt/format/
>
>>
>> Examples:
>> error=/sys/kernel/debug/scsi_debug/0:0:0:1/error
>> echo "0 -10 0x12" > ${error}
>
> These examples are misleading. Same with the one in patch 7/10 . The example
> should be showing an invocation that exercises _this_ patch. So the first
> byte of the echo should be 4 not the 0 shown above.
>
> Doug Gilbert
>
Would update in next version. Would you continue reviewing patch 9/10 and 10/10?
Powered by blists - more mailing lists