| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231007125550.529700-1-peng.fan@oss.nxp.com>
Date: Sat, 7 Oct 2023 20:55:50 +0800
From: "Peng Fan (OSS)" <peng.fan@....nxp.com>
To: linus.walleij@...aro.org, brgl@...ev.pl, andy@...nel.org
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
Peng Fan <peng.fan@....com>,
Marco Felsch <m.felsch@...gutronix.de>
Subject: [PATCH] gpio: vf610: update comment for i.MX8ULP and i.MX93 legacy compatibles
From: Peng Fan <peng.fan@....com>
i.MX8ULP and i.MX93 legacy compatible strings use dual regs, while
new compatible strings use one reg. The "support old compatible strings"
is not clear to reflect the fact, so update it.
Suggested-by: Marco Felsch <m.felsch@...gutronix.de>
Signed-off-by: Peng Fan <peng.fan@....com>
---
To address:
https://lore.kernel.org/all/20231004050428.o7l2e23xjcjkzzck@pengutronix.de/
Marco:
I added your tag with Suggested-by, since you suggested this.
drivers/gpio/gpio-vf610.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
index c03dfda41d4c..a89ae84a1fa0 100644
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@ -287,7 +287,10 @@ static int vf610_gpio_probe(struct platform_device *pdev)
dual_base = port->sdata->have_dual_base;
- /* support old compatible strings */
+ /*
+ * Handle legacy compatible combinations which used two reg values
+ * for the i.MX8ULP and i.MX93.
+ */
if (device_is_compatible(dev, "fsl,imx7ulp-gpio") &&
(device_is_compatible(dev, "fsl,imx93-gpio") ||
(device_is_compatible(dev, "fsl,imx8ulp-gpio"))))
--
2.37.1
Powered by blists - more mailing lists