[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <364ac434.4e95.18b07c644b7.Coremail.dinghao.liu@zju.edu.cn>
Date: Sat, 7 Oct 2023 09:35:16 +0800 (GMT+08:00)
From: dinghao.liu@....edu.cn
To: "Stefan Schmidt" <stefan@...enfreihafen.org>
Cc: "kernel test robot" <lkp@...el.com>, oe-kbuild-all@...ts.linux.dev,
stable@...r.kernel.org, "Alexander Aring" <alex.aring@...il.com>,
"Miquel Raynal" <miquel.raynal@...tlin.com>,
"Eric Dumazet" <edumazet@...gle.com>,
"Jakub Kicinski" <kuba@...nel.org>,
"Paolo Abeni" <pabeni@...hat.com>,
"Harry Morris" <harrymorris12@...il.com>,
"Marcel Holtmann" <marcel@...tmann.org>,
linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v3] ieee802154: ca8210: Fix a potential UAF in
ca8210_probe
> Hello Dinghao,
>
>
> On 01.10.23 09:19, kernel test robot wrote:
> > Hi Dinghao,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on linus/master]
> > [also build test WARNING on v6.6-rc3 next-20230929]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Dinghao-Liu/ieee802154-ca8210-Fix-a-potential-UAF-in-ca8210_probe/20231001-135130
> > base: linus/master
> > patch link: https://lore.kernel.org/r/20231001054949.14624-1-dinghao.liu%40zju.edu.cn
> > patch subject: [PATCH] [v3] ieee802154: ca8210: Fix a potential UAF in ca8210_probe
> > config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231001/202310011548.qyQMuodI-lkp@intel.com/config)
> > compiler: m68k-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231001/202310011548.qyQMuodI-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202310011548.qyQMuodI-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/net/ieee802154/ca8210.c: In function 'ca8210_register_ext_clock':
> >>> drivers/net/ieee802154/ca8210.c:2743:13: warning: unused variable 'ret' [-Wunused-variable]
> > 2743 | int ret = 0;
> > | ^~~
> >
>
> Please take care of this now unused variable after your re-factor.
> With this fixed and send out as v4 I am happy to get this applied to the
> wpan tree.
I will resend the v4 patch soon, thanks!
Regards,
Dinghao
Powered by blists - more mailing lists