linux-kernel - Re: [PATCH 15/29] jffs2: move jffs2_xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 7 Oct 2023 09:39:39 +0800
From:   Zhihao Cheng <chengzhihao1@...wei.com>
To:     Wedson Almeida Filho <wedsonaf@...il.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>,
        <linux-fsdevel@...r.kernel.org>
CC:     <linux-kernel@...r.kernel.org>,
        Wedson Almeida Filho <walmeida@...rosoft.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Richard Weinberger <richard@....at>,
        <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH 15/29] jffs2: move jffs2_xattr_handlers to .rodata

在 2023/9/30 13:00, Wedson Almeida Filho 写道:
> From: Wedson Almeida Filho <walmeida@...rosoft.com>
> 
> This makes it harder for accidental or malicious changes to
> jffs2_xattr_handlers at runtime.
> 
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Richard Weinberger <richard@....at>
> Cc: linux-mtd@...ts.infradead.org
> Signed-off-by: Wedson Almeida Filho <walmeida@...rosoft.com>
> ---
>   fs/jffs2/xattr.c | 2 +-
>   fs/jffs2/xattr.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>

> diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c
> index 3b6bdc9a49e1..00224f3a8d6e 100644
> --- a/fs/jffs2/xattr.c
> +++ b/fs/jffs2/xattr.c
> @@ -920,7 +920,7 @@ struct jffs2_xattr_datum *jffs2_setup_xattr_datum(struct jffs2_sb_info *c,
>    * do_jffs2_setxattr(inode, xprefix, xname, buffer, size, flags)
>    *   is an implementation of setxattr handler on jffs2.
>    * -------------------------------------------------- */
> -const struct xattr_handler *jffs2_xattr_handlers[] = {
> +const struct xattr_handler * const jffs2_xattr_handlers[] = {
>   	&jffs2_user_xattr_handler,
>   #ifdef CONFIG_JFFS2_FS_SECURITY
>   	&jffs2_security_xattr_handler,
> diff --git a/fs/jffs2/xattr.h b/fs/jffs2/xattr.h
> index 1b5030a3349d..7e7de093ec0a 100644
> --- a/fs/jffs2/xattr.h
> +++ b/fs/jffs2/xattr.h
> @@ -94,7 +94,7 @@ extern int do_jffs2_getxattr(struct inode *inode, int xprefix, const char *xname
>   extern int do_jffs2_setxattr(struct inode *inode, int xprefix, const char *xname,
>   			     const char *buffer, size_t size, int flags);
>   
> -extern const struct xattr_handler *jffs2_xattr_handlers[];
> +extern const struct xattr_handler * const jffs2_xattr_handlers[];
>   extern const struct xattr_handler jffs2_user_xattr_handler;
>   extern const struct xattr_handler jffs2_trusted_xattr_handler;
>   
>