linux-kernel - Re: [cocci] [PATCH 2/2] scripts: coccicheck: Separate spatch stdout and stderr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2310072140340.36842@hadrien>
Date:   Sat, 7 Oct 2023 21:41:15 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Anton Eliasson <anton.eliasson@...s.com>
cc:     Nicolas Palix <nicolas.palix@...g.fr>, cocci@...ia.fr,
        linux-kernel@...r.kernel.org, kernel@...s.com
Subject: Re: [cocci] [PATCH 2/2] scripts: coccicheck: Separate spatch stdout
 and stderr



On Tue, 3 Oct 2023, Anton Eliasson wrote:

> This helps automating coccicheck runs by discarding stderr and only
> looking at the output of stdout. In report mode the only remaining
> output on stdout is the initial "Please check for false positives"
> message followed by each spatch warning found.

What is getting dropped is the spatch command lines indicating the
semantic patch.  Is this desirable?

julia

>
> Signed-off-by: Anton Eliasson <anton.eliasson@...s.com>
> ---
>  scripts/coccicheck | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 95a312730e98..7e7c44125f47 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -146,8 +146,8 @@ run_cmd_parmap() {
>                  echo $@>>$DEBUG_FILE
>                  $@ 2>>$DEBUG_FILE
>          else
> -                echo $@
> -                $@ 2>&1
> +                echo $@ >&2
> +                $@
>  	fi
>
>  	err=$?
>
> --
> 2.30.2
>
>