linux-kernel - Re: [PATCH v2] padata: Fix the UAF issue related to parallel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZSDYLKRcGFp2Kcxe@fedora>
Date:   Sat, 7 Oct 2023 12:01:48 +0800
From:   Wang Jinchao <wangjinchao@...sion.com>
To:     Daniel Jordan <daniel.m.jordan@...cle.com>
CC:     Steffen Klassert <steffen.klassert@...unet.com>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] padata: Fix the UAF issue related to parallel_data

On Wed, Oct 04, 2023 at 03:07:10PM -0400, Daniel Jordan wrote:
> On Wed, Oct 04, 2023 at 10:54:29AM -0400, Daniel Jordan wrote:
> > On Thu, Sep 28, 2023 at 08:38:53AM +0800, Wang Jinchao wrote:
...
> > This could use a Fixes tag.  From Nicolai's patch[0] we agreed on
> > 
> > Fixes: 07928d9bfc81 ("padata: Remove broken queue flushing")
> > 
> > With that,
> > 
> > Acked-by: Daniel Jordan <daniel.m.jordan@...cle.com>
> > 
> > Thanks!
> > 
...
> 
> Oh, I should've also said please move the declaration of pd to the top
> of the function like scripts/checkpatch.pl suggests.
> 
> > > +	if (refcount_dec_and_test(&pd->refcnt))
> > > +		padata_free_pd(pd);
> > >  	mutex_unlock(&ps->pinst->lock);
> > >  
> > >  	kfree(ps);
> > > -- 
> > > 2.40.0
> > > 
Thanks for suggestion, both were updated in V3.
V3: https://lore.kernel.org/all/ZSDWAcUxXcwD4YUZ@fedora/