[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023100855-railroad-wrecking-25af@gregkh>
Date: Sun, 8 Oct 2023 06:53:49 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Yury Norov <yury.norov@...il.com>
Cc: linux-kernel@...r.kernel.org,
"Rafael J. Wysocki" <rafael@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Brendan Higgins <brendan.higgins@...ux.dev>,
David Gow <davidgow@...gle.com>,
Hans de Goede <hdegoede@...hat.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
James Seo <james@...iv.tech>, Jason Baron <jbaron@...mai.com>,
Kees Cook <keescook@...omium.org>,
Kefeng Wang <wangkefeng.wang@...wei.com>,
Marco Elver <elver@...gle.com>,
Mark Brown <broonie@...nel.org>,
Ming Lei <ming.lei@...hat.com>,
Petr Tesarik <petr.tesarik.ext@...wei.com>,
Rae Moar <rmoar@...gle.com>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/2] lib/bitmap: move bitmap allocators for device to
linux/device.h
On Sat, Oct 07, 2023 at 04:35:09PM -0700, Yury Norov wrote:
> The allocators are simple wrappers around bitmap_{alloc,free}().
> So move them from bitmap to device sources.
No, they belong in the bitmap.h file, as they are devm_* versions of the
same functions in this file. They don't belong in the device.h file.
> Similarly to other device wrappers, turn them to static inlines
> and place in header.
Why do these need to be inline functions?
thanks,
greg k-h
Powered by blists - more mailing lists