linux-kernel - Re: [PATCH] f2fs: avoid format-overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 8 Oct 2023 14:45:23 +0800
From:   Chao Yu <chao@...nel.org>
To:     Su Hui <suhui@...china.com>, jaegeuk@...nel.org
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] f2fs: avoid format-overflow warning

On 2023/10/8 14:39, Su Hui wrote:
> With gcc and W=1 option, there's a warning like this:
> 
> fs/f2fs/compress.c: In function ‘f2fs_init_page_array_cache’:
> fs/f2fs/compress.c:1984:47: error: ‘%u’ directive writing between
> 1 and 7 bytes into a region of size between 5 and 8
> [-Werror=format-overflow=]
>   1984 |  sprintf(slab_name, "f2fs_page_array_entry-%u:%u", MAJOR(dev),
> 		MINOR(dev));
>        |                                               ^~
> 
> String "f2fs_page_array_entry-%u:%u" can up to 35. The first "%u" can up
> to 4 and the second "%u" can up to 7, so total size is "24 + 4 + 7 = 35".
> slab_name's size should be 35 rather than 32.
> 
> Signed-off-by: Su Hui <suhui@...china.com>

Looks good to me, thanks for the patch.

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,